Allow Gateway spec.listeners[].port and spec.infrastructure configuration via Helm values
#3508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbusko
changed the title
listeners[].port and spec.infrastructure configuration via Helm valuesspec.listeners[].port and spec.infrastructure configuration via Helm values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
no
What is this change about?
This change adds new values to the Helm chart for configuring
listeners[].portandspec.infrastructureproperties of the Gateway object. These properties simplify local setup as well as improve integration with various components around the Gateway and it's generated resources (like passing annotations from gateway down to the generatedServiceobject, which might be used by Gardener'sexternal-dns-managementcomponent).Does this PR introduce a breaking change?
no
Acceptance Steps
Tag your pair, your PM, and/or team